From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1eIz-0004E1-Oy for qemu-devel@nongnu.org; Wed, 06 May 2009 06:24:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1eIw-0004C4-1u for qemu-devel@nongnu.org; Wed, 06 May 2009 06:24:49 -0400 Received: from [199.232.76.173] (port=36401 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1eIv-0004Bz-Eu for qemu-devel@nongnu.org; Wed, 06 May 2009 06:24:45 -0400 Received: from mx1.redhat.com ([66.187.233.31]:59188) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1eIv-0002N4-44 for qemu-devel@nongnu.org; Wed, 06 May 2009 06:24:45 -0400 Date: Wed, 6 May 2009 11:24:41 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2 Message-ID: <20090506102441.GF23167@redhat.com> References: <1241571650-16212-1-git-send-email-alex@csgraf.de> <20090506082810.GB23167@redhat.com> <4A0154E9.7020705@redhat.com> <20090506093143.GC23167@redhat.com> <4A015F06.7050102@redhat.com> <20090506100628.GD23167@redhat.com> <20090506101324.GE23167@redhat.com> <4A016361.60908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A016361.60908@redhat.com> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: alex@csgraf.de, nolan@sigbus.net, Avi Kivity , qemu-devel@nongnu.org On Wed, May 06, 2009 at 12:16:01PM +0200, Kevin Wolf wrote: > Daniel P. Berrange schrieb: > > Oh and if you want to be really nice, you could say that any filename > > with a leading '/' is implicitly file:///, since I can't imagine > > any protocol name starting with a '/'. And this would ensure any > > existing usage with absolute filenames 'just works' without tripping > > up on colons. > > Existing usage would mean to get an error message. I don't see any > reason why we should change this behaviour if we have a real solution. > Adding more exceptions to the guessing doesn't really make it more harmless. By existing usage, I meant the practice of supplying an absolute filename to QEMU, which works all the time, except if you're unlucky to have a colon in the filename, in which case it breaks, even though it could trivially work. Getting an error for an absolute path with a colon is a bug IMHO, rather than useful behaviour. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|