From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1hLQ-0006Qi-Qp for qemu-devel@nongnu.org; Wed, 06 May 2009 09:39:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1hLL-0006Pv-90 for qemu-devel@nongnu.org; Wed, 06 May 2009 09:39:31 -0400 Received: from [199.232.76.173] (port=38553 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1hLL-0006Ps-3C for qemu-devel@nongnu.org; Wed, 06 May 2009 09:39:27 -0400 Received: from mx1.redhat.com ([66.187.233.31]:47831) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1hLK-0006HD-Lm for qemu-devel@nongnu.org; Wed, 06 May 2009 09:39:26 -0400 Date: Wed, 6 May 2009 14:39:20 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2 Message-ID: <20090506133920.GK23167@redhat.com> References: <1241571650-16212-1-git-send-email-alex@csgraf.de> <20090506082810.GB23167@redhat.com> <4A0154E9.7020705@redhat.com> <20090506093143.GC23167@redhat.com> <4A015F06.7050102@redhat.com> <4A018CD8.6000200@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A018CD8.6000200@codemonkey.ws> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , alex@csgraf.de, nolan@sigbus.net, Avi Kivity , qemu-devel@nongnu.org On Wed, May 06, 2009 at 08:12:56AM -0500, Anthony Liguori wrote: > Avi Kivity wrote: > >Daniel P. Berrange wrote: > >>Then I'd prefer we add a protocol=XXX option for magic protocols. > >>This would be easier to use & clearer than requiring escaping of > >>magic characters, eg > >> > >> -drive file=/some/path:with:colons,protocol=file > >> -drive file=http://some/path,protocol=uri > >> > >>For compatability, we could make it such that if protocol=XXX was > >>left out, > >>it could try and "guess" it, in same way QEMU does if format=XXX is > >>left out > >>for content format. > >> > > > >How about > > > > -drive file=file:///some/path:with:colons? > > > >Libvirt would use this unconditionally, command-line users can choose. > > Why does libvirt care? That confuses me. I don't have any problem with QEMU supporting http, nbd, or other clever file access schemes. I'll let others debate its merits vs using FUSE http filesystems :-) All I care about from libvirt POV, is that there is a way to give QEMU an absolute file path for a disk, and guarentee that QEMU will treat this as a local file path, and not try any access protocols, other than 'open(2)'. Various options from this thread.... - Treat any path starting with / as local file - Allow file: as a prefix - Allow file:/// as a prefix, real URI style - Add a protocol=file flag to -drive Pick one, pick several, suggest more. Any of these options would work as far as I'm concerned, and we could easily support several. I think the first is desirable because that's the natural thing users will try when launching QEMU directly. I see the merit in also having file: or file:/// as an explicit protocol too. I think the 4th protocol=file is redundant really, given that we have precedent of using XXX: prefixes in nbd driver Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|