[Qemu-devel] Re: [PATCH 4/4] move apic functions to a separate apic.h header

[Glauber Costa <glommer@redhat.com>]

On Wed, May 06, 2009 at 05:52:04PM +0200, Jan Kiszka wrote:
> Glauber Costa wrote:
> > Later on, we'll want to call an apic function from helper.c.
> > The inclusion of pc.h, besides totally ugly, leads to a lot of
> > clashes.
> > 
> > Signed-off-by: Glauber Costa <glommer@redhat.com>
> > ---
> >  hw/apic.c        |    1 +
> >  hw/apic.h        |   19 +++++++++++++++++++
> >  hw/ioapic.c      |    1 +
> >  hw/mc146818rtc.c |    1 +
> >  hw/pc.c          |    1 +
> >  hw/pc.h          |   15 ---------------
> >  6 files changed, 23 insertions(+), 15 deletions(-)
> >  create mode 100644 hw/apic.h
> > 
> > diff --git a/hw/apic.c b/hw/apic.c
> > index d63d74b..72dbe88 100644
> > --- a/hw/apic.c
> > +++ b/hw/apic.c
> > @@ -19,6 +19,7 @@
> >   */
> >  #include "hw.h"
> >  #include "pc.h"
> > +#include "apic.h"
> 
> Does it still need pc.h then?
yes. For things like RTCState.

> 
> >  #include "qemu-timer.h"
> >  #include "host-utils.h"
> >  
> > diff --git a/hw/apic.h b/hw/apic.h
> > new file mode 100644
> > index 0000000..2437e9f
> > --- /dev/null
> > +++ b/hw/apic.h
> > @@ -0,0 +1,19 @@
> > +#ifndef _APIC_H_
> > +#define _APIC_H_
> 
> "APIC_H", otherwise fine.
ok.