From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M201J-0000eI-G2
	for qemu-devel@nongnu.org; Thu, 07 May 2009 05:36:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M201E-0000dI-BU
	for qemu-devel@nongnu.org; Thu, 07 May 2009 05:36:00 -0400
Received: from [199.232.76.173] (port=52808 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M201E-0000d8-5I
	for qemu-devel@nongnu.org; Thu, 07 May 2009 05:35:56 -0400
Received: from mx20.gnu.org ([199.232.41.8]:60797)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <mst@redhat.com>) id 1M201D-0000Bb-Og
	for qemu-devel@nongnu.org; Thu, 07 May 2009 05:35:55 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1M201D-0003Zv-3K
	for qemu-devel@nongnu.org; Thu, 07 May 2009 05:35:55 -0400
Date: Thu, 7 May 2009 12:34:50 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090507093450.GE32039@redhat.com>
References: <20090507084019.GA25512%yamahata@valinux.co.jp>
	<20090507085010.GA32039@redhat.com>
	<20090507090639.GB25512%yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090507090639.GB25512%yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: pci_default_config_write() clean up.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Thu, May 07, 2009 at 06:06:39PM +0900, Isaku Yamahata wrote:
> On Thu, May 07, 2009 at 11:50:10AM +0300, Michael S. Tsirkin wrote:
> > Hmm, this adds more code that it removes.
> > Did you take a look at my attempt at the rewrite of the same function?
> 
> Yes, so I added you on Cc.
> The most of code is trivial tables,
> so I don't think it complicates the logic.

Well, one still needs to wade through them to figure out
how things work.

> If we want more precise emulation, your pci_init_mask()
> will bigger anyway.

The diffstat for both patches tells a different story :)

-- 
MST