From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M296i-00034y-T6
	for qemu-devel@nongnu.org; Thu, 07 May 2009 15:18:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M296e-00032x-DR
	for qemu-devel@nongnu.org; Thu, 07 May 2009 15:18:12 -0400
Received: from [199.232.76.173] (port=33994 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M296e-00032s-9o
	for qemu-devel@nongnu.org; Thu, 07 May 2009 15:18:08 -0400
Received: from mx2.redhat.com ([66.187.237.31]:59851)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1M296d-0004gs-IU
	for qemu-devel@nongnu.org; Thu, 07 May 2009 15:18:08 -0400
Date: Thu, 7 May 2009 16:22:34 -0300
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] move apic functions to a separate
	apic.h header
Message-ID: <20090507192234.GA5953@poweredge.glommer>
References: <1241722263-26541-1-git-send-email-glommer@redhat.com>
	<1241722263-26541-2-git-send-email-glommer@redhat.com>
	<1241722263-26541-3-git-send-email-glommer@redhat.com>
	<1241722263-26541-4-git-send-email-glommer@redhat.com>
	<1241722263-26541-5-git-send-email-glommer@redhat.com>
	<Pine.LNX.4.64.0905072311040.2213@linmac.oyster.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0905072311040.2213@linmac.oyster.ru>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, May 07, 2009 at 11:12:17PM +0400, malc wrote:
> On Thu, 7 May 2009, Glauber Costa wrote:
> 
> > Later on, we'll want to call an apic function from helper.c.
> > The inclusion of pc.h, besides totally ugly, leads to a lot of
> > clashes.
> 
> [..snip..]
> 
> > +#ifndef _APIC_H_
> > +#define _APIC_H_
> 
> Looks like you forgot to fix that.
ughhh

you're right.

Anthony, mind committing the other patches? (if they are okay?)
I can then send just this one, to avoid confusion