From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M34ao-0007eC-Cc for qemu-devel@nongnu.org; Sun, 10 May 2009 04:41:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M34aj-0007Zi-DY for qemu-devel@nongnu.org; Sun, 10 May 2009 04:41:05 -0400 Received: from [199.232.76.173] (port=50397 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M34ai-0007ZV-U8 for qemu-devel@nongnu.org; Sun, 10 May 2009 04:41:01 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54448) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M34ai-0001fF-IN for qemu-devel@nongnu.org; Sun, 10 May 2009 04:41:00 -0400 Date: Sun, 10 May 2009 11:38:43 +0300 From: "Michael S. Tsirkin" Message-ID: <20090510083843.GB5335@redhat.com> References: <20090508034301.GF25512%yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090508034301.GF25512%yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: pci_default_config_write() clean up List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: blauwirbel@gmail.com, mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Fri, May 08, 2009 at 12:43:01PM +0900, Isaku Yamahata wrote: > > Here is the ver2 pci_default_config_write() clean up > following to comments. > > I didn't use per-dword callback. Although special cycles > specifies dword address, qemu emulation is not bus level, > but instruction level. > > Maybe callback function signature might be arguable. > But at this moment there is no real user, so I'd like > to postpone its argument until real user appears. Looking at real users, I'm not sure the number of users makes the whole callback thing worth it. -- MST