From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Chih-Min Chao <cmchao@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] suppress 'warn_unused_result' warning
Date: Sun, 10 May 2009 23:11:22 +0100 [thread overview]
Message-ID: <200905102311.27268.paul@codesourcery.com> (raw)
In-Reply-To: <ee84806e0905101215gf32927j1b510a0084038e20@mail.gmail.com>
On Sunday 10 May 2009, Chih-Min Chao wrote:
> The patch add error handling to functions with 'warn_unused_result' return
> value
> such as write, read, ftruncate, and realpath.
I'm pretty sure this is wrong. It feels a lot like blindly papering over
compiler warnings without actually understanding what's going on.
In some cases errors are actually an expected part of normal operation. In
many other cases you only handle complete failure, and not partial
completion.
Paul
next prev parent reply other threads:[~2009-05-10 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 19:15 [Qemu-devel] [PATCH] suppress 'warn_unused_result' warning Chih-Min Chao
2009-05-10 22:11 ` Paul Brook [this message]
2009-05-10 22:15 ` Stuart Brady
2009-05-10 23:19 ` Anthony Liguori
2009-05-11 1:53 ` M. Warner Losh
2009-05-11 15:42 ` Stuart Brady
2009-05-11 16:02 ` Paul Brook
2009-05-11 16:16 ` Anthony Liguori
2009-05-11 16:25 ` Daniel P. Berrange
2009-05-11 16:57 ` Anthony Liguori
2009-05-12 12:19 ` Jamie Lokier
2009-05-11 17:02 ` Jamie Lokier
2009-05-11 16:15 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905102311.27268.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=cmchao@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).