From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M440d-0003MI-N7
	for qemu-devel@nongnu.org; Tue, 12 May 2009 22:15:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M440Y-0003Lw-FM
	for qemu-devel@nongnu.org; Tue, 12 May 2009 22:15:50 -0400
Received: from [199.232.76.173] (port=60137 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M440Y-0003Lt-AD
	for qemu-devel@nongnu.org; Tue, 12 May 2009 22:15:46 -0400
Received: from mx20.gnu.org ([199.232.41.8]:1816)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <froydnj@codesourcery.com>)
	id 1M440Y-00040u-1U
	for qemu-devel@nongnu.org; Tue, 12 May 2009 22:15:46 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <froydnj@codesourcery.com>) id 1M440X-0004ng-2U
	for qemu-devel@nongnu.org; Tue, 12 May 2009 22:15:45 -0400
Date: Tue, 12 May 2009 19:15:44 -0700
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] linux-user: add ppc signal handling, v2
Message-ID: <20090513021544.GW23911@codesourcery.com>
References: <1242156419-23821-1-git-send-email-froydnj@codesourcery.com>
	<Pine.LNX.4.64.0905130305530.11267@linmac.oyster.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0905130305530.11267@linmac.oyster.ru>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, May 13, 2009 at 03:13:10AM +0400, malc wrote:
> On Tue, 12 May 2009, Nathan Froyd wrote:
> > This patch series adds signal handling support for 32-bit PPC linux-user
> > emulation.  It requires a bit of shuffling of target-ppc code to ensure
> > that we know what the capabilities of our current CPU are so we know
> > which registers to save.
> 
> This one works as is, however the series introduces 3 instances of
> trailing whitespace (git complains) and few new tab characters (my
> eyes do).

Sorry about that; fixed in a reply to part 2/3 of the patch series.

> Plus while building it (this time with gcc 3.4.6) i noticed
> that the warnings around __put_user are gone, but lines 2746 and 2747
> of op_helper.c produce (both originate from d9430add, which is also
> yours):
> 
> warning: array subscript is above array bounds
> 
> Boils down to:
> 
> #define VSHIFT(suffix, leftp)                                           \
>     void helper_vs##suffix (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)   \
>     {                                                                   \
>         int shift = b->u8[LO_IDX*0x15] & 0x7;                           \
> 
> I'd venture a guess that '*15' instead was meant to be there.

Indeed.  I will fix this in a separate patch unless you beat me to
it. :)  Thanks for the heads-up.

-Nathan