From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M49W0-0005V3-3n
	for qemu-devel@nongnu.org; Wed, 13 May 2009 04:08:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M49Vu-0005SW-QO
	for qemu-devel@nongnu.org; Wed, 13 May 2009 04:08:35 -0400
Received: from [199.232.76.173] (port=49867 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M49Vu-0005SQ-Mh
	for qemu-devel@nongnu.org; Wed, 13 May 2009 04:08:30 -0400
Received: from mx2.redhat.com ([66.187.237.31]:41583)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1M49Vu-0002H1-6n
	for qemu-devel@nongnu.org; Wed, 13 May 2009 04:08:30 -0400
Date: Wed, 13 May 2009 11:07:24 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090513080724.GA31593@redhat.com>
References: <1242201052-20536-1-git-send-email-yamahata@valinux.co.jp>
	<1242201052-20536-3-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1242201052-20536-3-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 2/4] qemu: make default_write_config use
	mask table
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Wed, May 13, 2009 at 04:50:50PM +0900, Isaku Yamahata wrote:
> Change much of hw/pci to use symbolic constants and a table-driven
> design: add a mask table with writable bits set and readonly bits unset.
> Detect change by comparing original and new registers.
> 
> As a result, writing a single byte in BAR registers now works as it
> should. Writing to upper limit registers in the bridge also works as it
> should. Writes to BAR registers trigger mapping update.  Code is also
> shorter.
> 
> Changelog since v1
> - simplify the code some more
> - use PCI_CONFIG_SPACE_SIZE instead of 0x100
> - only trigger pci update when IO/MEM bits in command register have changed
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

You must also add
From: Michael S. Tsirkin <mst@redhat.com>

at the top, otherwise git won't record the authorship
information in log correctly.

-- 
MST