From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4CBM-0006gB-IL for qemu-devel@nongnu.org; Wed, 13 May 2009 06:59:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4CBI-0006fy-6R for qemu-devel@nongnu.org; Wed, 13 May 2009 06:59:28 -0400 Received: from [199.232.76.173] (port=36058 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4CBI-0006fv-1U for qemu-devel@nongnu.org; Wed, 13 May 2009 06:59:24 -0400 Received: from verein.lst.de ([213.95.11.210]:37706) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1M4CBH-00017T-FV for qemu-devel@nongnu.org; Wed, 13 May 2009 06:59:23 -0400 Date: Wed, 13 May 2009 12:59:17 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] qcow2: Drop synchronous qcow_write() Message-ID: <20090513105917.GA5349@lst.de> References: <1242211593-16495-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1242211593-16495-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Wed, May 13, 2009 at 12:46:33PM +0200, Kevin Wolf wrote: > There is only one (internal) user left and it can be switched to the normal > emulation provided in block.c. Leaving it as it is would mean that creating > compressed images uses a different codepath than everything else, so there > would be a risk of a breakage that wouldn't be covered by much testing. Looks good to me, that strary qcow2_write irked me, too. Do you plan to kill qcow_read, too? Also the same patch should into qcow, too.