From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M4n20-0001Hz-BF
	for qemu-devel@nongnu.org; Thu, 14 May 2009 22:20:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M4n1u-0001HL-Pe
	for qemu-devel@nongnu.org; Thu, 14 May 2009 22:20:14 -0400
Received: from [199.232.76.173] (port=33826 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M4n1u-0001HI-Ll
	for qemu-devel@nongnu.org; Thu, 14 May 2009 22:20:10 -0400
Received: from mx20.gnu.org ([199.232.41.8]:46443)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1M4n1u-0007CJ-En
	for qemu-devel@nongnu.org; Thu, 14 May 2009 22:20:10 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1M4n1t-0004pS-Iq
	for qemu-devel@nongnu.org; Thu, 14 May 2009 22:20:09 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] fix ARMv7 data processing instructions
Date: Fri, 15 May 2009 03:19:46 +0100
References: <61DFBCBD-0A9A-42E9-9E3E-F71E69BD6DFE@nokia.com>
	<200905150305.57613.paul@codesourcery.com>
In-Reply-To: <200905150305.57613.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200905150319.46630.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Juha =?iso-8859-15?q?Riihim=E4ki?= <juha.riihimaki@nokia.com>

On Friday 15 May 2009, Paul Brook wrote:
> On Wednesday 06 May 2009, Juha Riihim=E4ki wrote:
> > ARMv7 defines a new behavior for ARM data processing instructions
> > compared to earlier architecture revisions; when the destination
> > register is R15, a Branch and Exchange operation is executed rather
> > than a simple Branch to the target address. This patch corrects the
> > behavior of the emulation for the aforementioned operations.
>
> We should not switch modes if instructions sets the condition flags.

On second looks, we get those cases wrong anyway, so I've applied the patch.

Paul