From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4uMp-0003c8-Ig for qemu-devel@nongnu.org; Fri, 15 May 2009 06:10:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4uMk-0003Zs-FF for qemu-devel@nongnu.org; Fri, 15 May 2009 06:10:14 -0400 Received: from [199.232.76.173] (port=37152 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4uMk-0003Zi-AR for qemu-devel@nongnu.org; Fri, 15 May 2009 06:10:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:1440) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M4uMk-0000rl-1P for qemu-devel@nongnu.org; Fri, 15 May 2009 06:10:10 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M4uMj-0004Nn-Cc for qemu-devel@nongnu.org; Fri, 15 May 2009 06:10:09 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Revived GUEST_BASE support for usermode emulation targets [v4] Date: Fri, 15 May 2009 11:09:48 +0100 References: <1241028203-19687-1-git-send-email-riku.voipio@iki.fi> <20090515095728.GA24314@kos.to> <200905151102.58522.paul@codesourcery.com> In-Reply-To: <200905151102.58522.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905151109.48825.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: martin.mohring@opensuse.org, mika.westerberg@iki.fi, Riku Voipio > > It is indeed broken. Since tcg_out_addi maps on x86_64 to tgen_arithi64 > > which doesn't accept 64bit values. But as Martin said, the currrent use > > for this patch is just to add very minimal offsets. > > I that case you should be using lea for small offsets. The proper sequence > for large offsets is movq (allows 64-bit immedaise); add. > > The offset is a user configurable option, so IMHO you should be supporting > large offsets. I'll also note that mmap_min_addr need not be a small value. It may be set to ~4G to flush out 32-bit pointer truncation errors. Paul