From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M5gsV-0002ZE-Qf
	for qemu-devel@nongnu.org; Sun, 17 May 2009 09:58:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M5gsQ-0002Z2-Ap
	for qemu-devel@nongnu.org; Sun, 17 May 2009 09:58:10 -0400
Received: from [199.232.76.173] (port=34009 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M5gsQ-0002Yz-63
	for qemu-devel@nongnu.org; Sun, 17 May 2009 09:58:06 -0400
Received: from mx20.gnu.org ([199.232.41.8]:38347)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1M5gsP-0002Yf-Qt
	for qemu-devel@nongnu.org; Sun, 17 May 2009 09:58:05 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1M5gsO-0001Kp-3z
	for qemu-devel@nongnu.org; Sun, 17 May 2009 09:58:04 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev
	infrastructure.
Date: Sun, 17 May 2009 14:57:28 +0100
References: <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com>
	<f43fc5580905152312q7f664c07tc21243556538dcac@mail.gmail.com>
In-Reply-To: <f43fc5580905152312q7f664c07tc21243556538dcac@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905171457.28997.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

> >  +struct DeviceProperty {
> >  +        int i;
>
> qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t.

Fixed.

> >  +struct DeviceType {
> >  +    int size;
>
> size_t size?

Technically yes. However if we ever get devices with >2G of internal state we 
have much bigger problems :-)

Paul