* [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure. [not found] <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com> @ 2009-05-16 6:12 ` Blue Swirl 2009-05-17 13:57 ` Paul Brook 0 siblings, 1 reply; 2+ messages in thread From: Blue Swirl @ 2009-05-16 6:12 UTC (permalink / raw) To: Paul Brook; +Cc: qemu-devel On 5/15/09, Anthony Liguori <aliguori@us.ibm.com> wrote: > From: Paul Brook <paul@codesourcery.com> > > Signed-off-by: Paul Brook <paul@codesourcery.com> > +struct DeviceProperty { > + const char *name; > + union { > + int i; qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t. > +struct DeviceType { > + const char *name; > + qdev_initfn init; > + void *opaque; > + int size; size_t size? > +DeviceType *qdev_register(const char *name, int size, qdev_initfn init, > + void *opaque) size_t size? > +void qdev_set_prop_int(DeviceState *dev, const char *name, int value) > +uint64_t qdev_get_prop_int(DeviceState *dev, const char *name, uint64_t def) ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure. 2009-05-16 6:12 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure Blue Swirl @ 2009-05-17 13:57 ` Paul Brook 0 siblings, 0 replies; 2+ messages in thread From: Paul Brook @ 2009-05-17 13:57 UTC (permalink / raw) To: qemu-devel; +Cc: Blue Swirl > > +struct DeviceProperty { > > + int i; > > qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t. Fixed. > > +struct DeviceType { > > + int size; > > size_t size? Technically yes. However if we ever get devices with >2G of internal state we have much bigger problems :-) Paul ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-17 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com>
2009-05-16 6:12 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure Blue Swirl
2009-05-17 13:57 ` Paul Brook
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).