From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M5oTC-0001dG-ES
	for qemu-devel@nongnu.org; Sun, 17 May 2009 18:04:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M5oT6-0001b8-S0
	for qemu-devel@nongnu.org; Sun, 17 May 2009 18:04:33 -0400
Received: from [199.232.76.173] (port=41117 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M5oT6-0001b4-Kl
	for qemu-devel@nongnu.org; Sun, 17 May 2009 18:04:28 -0400
Received: from mx20.gnu.org ([199.232.41.8]:1818)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1M5oT6-0001M2-3Q
	for qemu-devel@nongnu.org; Sun, 17 May 2009 18:04:28 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1M5oT4-0000gY-Bu
	for qemu-devel@nongnu.org; Sun, 17 May 2009 18:04:26 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms
Date: Sun, 17 May 2009 23:04:19 +0100
References: <1242574141-18488-1-git-send-email-aliguori@us.ibm.com>
	<4A103143.4010202@redhat.com> <4A1032E8.1090706@us.ibm.com>
In-Reply-To: <4A1032E8.1090706@us.ibm.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905172304.22687.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, Dustin Kirkland <kirkland@canonical.com>, Avi Kivity <avi@redhat.com>, Alex Graf <alex@csgraf.de>

> >> We build the roms in a sub directory of the target build directory.
> >> This is
> >> anticipating a single source base (like uboot) that gets built
> >> differently for
> >> multiple target architectures (PPC, SH4, etc.).

I'm pretty sure this is going to be wrong. i386 and x86-64 use the same rom, 
and uboot will most likely need to be built for every *bard*

> >> +#  Per architecture ROMS
> >> +ROMS=
> >> +ifeq ($(TARGET_BASE_ARCH),i386)
> >> +ROMS+=gplbios vgabios
> >> +endif
> >> +
> >
> > ROMS-i386 = gplbios vgabios
> > ROMS = $(ROMS-$(TARGET_BASE_ARCH))
> >
> > (make is not shell, it tolerates spaces around the equals sign)
>
> Yeah, this is still very rough.  The build/install process is different
> for each rom so I'm probably going to need to do something fancier than
> what I have about.  Perhaps something along a subdir-% rule for the sane
> ROMs that can be overridden for weirder ones.
>
> gplbios and vgabios are simple to build so it's where I started.

This worries me. You've probably picked the easiest examples, and already it 
doesn't fit nicely.

Why are you trying so hard to integrate these into qemu? IMHO they really 
don't belong there. AFAICS the roms share no significant code with qemu, and 
require a completely different environment to build. Especially in cross 
environments I'd expect combining the two to cause much more pain than it's 
worth. When developing/building roms a native environment is the exception 
rather than the norm. Even then it's not really a native build, it's more a 
collection of hacks that allow you get away with using a native toolchain.

Paul