qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Dustin Kirkland <kirkland@canonical.com>,
	Glauber Costa <glommer@gmail.com>, Avi Kivity <avi@redhat.com>,
	Alex Graf <alex@csgraf.de>
Subject: Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms
Date: Mon, 18 May 2009 00:43:41 +0100	[thread overview]
Message-ID: <200905180043.43205.paul@codesourcery.com> (raw)
In-Reply-To: <4A109D9F.9040207@codemonkey.ws>

> >> gplbios and vgabios are simple to build so it's where I started.
> >
> > This worries me. You've probably picked the easiest examples, and already
> > it doesn't fit nicely.
> >
> > Why are you trying so hard to integrate these into qemu? IMHO they really
> > don't belong there. AFAICS the roms share no significant code with qemu,
> > and require a completely different environment to build. Especially in
> > cross environments I'd expect combining the two to cause much more pain
> > than it's worth. When developing/building roms a native environment is
> > the exception rather than the norm. Even then it's not really a native
> > build, it's more a collection of hacks that allow you get away with using
> > a native toolchain.
>
> For any packager, it's absolutely necessary to build all of the
> distributed binaries from source.

I don't disagree with this.

> In general, QEMU does not support anything but lock-step versioning with
> it's ROMs.  There is no ABI between QEMU and the BIOS.

This is obviously false for things like PXE roms.

> Having multiple packages therefore makes little sense because they can
> never be independent of each other.

Depends how your build system is setup.  IMHO building a ROM and building qemu 
itself are different tasks that effectively need separate packages anyway.

I also think that the Makefile is a bad place to encode knowledge of how to 
build a rom. If roms are hard to build and configure, shouldn't we be fixing 
that uptream? If not, isn't it going to be simpler and more effective to have 
a script that fetches+builds all the roms we ship?

> As long as we include binaries in our source tree, I think we ought to
> also include the source for those binaries.

You aren't importing the source though. You're just add makefile hacks to 
build it after it's been fetched from third party repositories.

Paul

  reply	other threads:[~2009-05-17 23:43 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-17 15:28 [Qemu-devel] [PATCH 0/4][RFC] Bring ROM source into tree via git submodules Anthony Liguori
2009-05-17 15:28 ` [Qemu-devel] [PATCH 1/4] Add GPL bios as a submodule Anthony Liguori
2009-05-17 15:43   ` [Qemu-devel] " Avi Kivity
2009-05-17 15:49     ` Anthony Liguori
2009-05-17 16:23       ` Avi Kivity
2009-05-17 17:51         ` Jamie Lokier
2009-05-17 18:03           ` Avi Kivity
2009-05-17 18:05           ` Stanislav
2009-05-17 18:11             ` Avi Kivity
2009-05-17 18:37               ` Stanislav
2009-05-17 19:07                 ` Avi Kivity
2009-05-17 22:12                   ` Carl-Daniel Hailfinger
2009-05-17 22:40                     ` Avi Kivity
2009-05-17 23:22                 ` Anthony Liguori
2009-05-18 15:20                   ` ron minnich
2009-05-18  2:40                 ` Kevin O'Connor
2009-05-17 23:13             ` Anthony Liguori
2009-05-18  4:22               ` Jamie Lokier
2009-05-25 13:04                 ` Carl-Daniel Hailfinger
2009-05-17 23:09         ` Anthony Liguori
2009-05-17 23:23           ` Avi Kivity
2009-05-17 23:31             ` Anthony Liguori
2009-05-17 23:40               ` Avi Kivity
2009-05-18  1:17                 ` Anthony Liguori
2009-05-18  5:48                   ` Avi Kivity
2009-05-17 17:10   ` Sebastian Herbszt
2009-05-17 15:28 ` [Qemu-devel] [PATCH 2/4] Add submodule for VGABios Anthony Liguori
2009-05-17 15:29 ` [Qemu-devel] [PATCH 3/4] Update makefile to build roms Anthony Liguori
2009-05-17 15:46   ` [Qemu-devel] " Avi Kivity
2009-05-17 15:47     ` Avi Kivity
2009-05-17 15:53     ` Anthony Liguori
2009-05-17 17:16       ` Avi Kivity
2009-05-17 23:10         ` Anthony Liguori
2009-05-17 22:04       ` Paul Brook
2009-05-17 23:28         ` Anthony Liguori
2009-05-17 23:43           ` Paul Brook [this message]
2009-05-18  1:18             ` Anthony Liguori
2009-05-18  4:24             ` Jamie Lokier
2009-05-18  8:25               ` Riku Voipio
2009-05-18  8:35                 ` Avi Kivity
2009-05-17 15:29 ` [Qemu-devel] [PATCH 4/4] Allow tool chain to be specified for bios build Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905180043.43205.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=alex@csgraf.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=glommer@gmail.com \
    --cc=kirkland@canonical.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).