From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5q1J-0002RK-8h for qemu-devel@nongnu.org; Sun, 17 May 2009 19:43:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5q1D-0002Qu-OC for qemu-devel@nongnu.org; Sun, 17 May 2009 19:43:52 -0400 Received: from [199.232.76.173] (port=52364 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5q1D-0002Qr-FY for qemu-devel@nongnu.org; Sun, 17 May 2009 19:43:47 -0400 Received: from mx20.gnu.org ([199.232.41.8]:6932) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M5q1D-0008Sw-03 for qemu-devel@nongnu.org; Sun, 17 May 2009 19:43:47 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M5q1B-0005QQ-Og for qemu-devel@nongnu.org; Sun, 17 May 2009 19:43:46 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms Date: Mon, 18 May 2009 00:43:41 +0100 References: <1242574141-18488-1-git-send-email-aliguori@us.ibm.com> <200905172304.22687.paul@codesourcery.com> <4A109D9F.9040207@codemonkey.ws> In-Reply-To: <4A109D9F.9040207@codemonkey.ws> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905180043.43205.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Dustin Kirkland , Glauber Costa , Avi Kivity , Alex Graf > >> gplbios and vgabios are simple to build so it's where I started. > > > > This worries me. You've probably picked the easiest examples, and already > > it doesn't fit nicely. > > > > Why are you trying so hard to integrate these into qemu? IMHO they really > > don't belong there. AFAICS the roms share no significant code with qemu, > > and require a completely different environment to build. Especially in > > cross environments I'd expect combining the two to cause much more pain > > than it's worth. When developing/building roms a native environment is > > the exception rather than the norm. Even then it's not really a native > > build, it's more a collection of hacks that allow you get away with using > > a native toolchain. > > For any packager, it's absolutely necessary to build all of the > distributed binaries from source. I don't disagree with this. > In general, QEMU does not support anything but lock-step versioning with > it's ROMs. There is no ABI between QEMU and the BIOS. This is obviously false for things like PXE roms. > Having multiple packages therefore makes little sense because they can > never be independent of each other. Depends how your build system is setup. IMHO building a ROM and building qemu itself are different tasks that effectively need separate packages anyway. I also think that the Makefile is a bad place to encode knowledge of how to build a rom. If roms are hard to build and configure, shouldn't we be fixing that uptream? If not, isn't it going to be simpler and more effective to have a script that fetches+builds all the roms we ship? > As long as we include binaries in our source tree, I think we ought to > also include the source for those binaries. You aren't importing the source though. You're just add makefile hacks to build it after it's been fetched from third party repositories. Paul