From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6n1P-0003JM-7H for qemu-devel@nongnu.org; Wed, 20 May 2009 10:43:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6n1I-0003FK-5X for qemu-devel@nongnu.org; Wed, 20 May 2009 10:43:52 -0400 Received: from [199.232.76.173] (port=56735 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6n1H-0003F5-U8 for qemu-devel@nongnu.org; Wed, 20 May 2009 10:43:47 -0400 Received: from bsdimp.com ([199.45.160.85]:55768 helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M6n1H-0007SZ-ED for qemu-devel@nongnu.org; Wed, 20 May 2009 10:43:47 -0400 Date: Wed, 20 May 2009 08:41:24 -0600 (MDT) Message-Id: <20090520.084124.1715680382.imp@bsdimp.com> Subject: Re: [Qemu-devel] block/raw-posix.c:hdev_create() on FreeBSD and in general From: "M. Warner Losh" In-Reply-To: <20090520080723.GA2957@lst.de> References: <20090520080723.GA2957@lst.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: hch@lst.de Cc: nolan@sigbus.net, qemu-devel@nongnu.org In message: <20090520080723.GA2957@lst.de> Christoph Hellwig writes: : Didn't FreeBSD do away with block device nodes in the 4.x release cycle? Yes. Block devices are a quaint relic of the past, and aren't needed. :) : In that case we will never allow to create host devices on FreeBSD : with this code. Yes, on FreeBSD, just use the char dev. : Also I think we should allow creating the host devices on all supported : operating systems. For Linux we should use block devices, for FreeBSD : always char devices. For the other BSDs and Solaris do we allow only : block or also the raw char devices? Not sure if they actually support : O_DIRECT for block devices nodes which pretty much is a Linux-ism so : for cache=none at least we should probably open the raw nodes.. Other BSDs still have block devices. O_DIRECT is supported in at least NetBSD (and FreeBSD). Warner