qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: john cooper <john.cooper@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: [PATCH 0/2] Add serial number support for virtio_blk, V2
Date: Wed, 20 May 2009 03:31:29 -0400	[thread overview]
Message-ID: <20090520073129.GA17378@infradead.org> (raw)
In-Reply-To: <4A117819.5060105@redhat.com>

On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote:
> Christoph Hellwig wrote:
>> On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote:
>>> [Resend of earlier patch: 1/2 rebased to qemu-kvm,
>>> 2/2 minor tweak]
>>
>> patch 1/2 seems to be missing.
> It is in the kvm and qemu-devel list archives:
>
> http://www.spinics.net/lists/kvm/maillist.html
> http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00661.html

Ah, it got posted as reply to the previous submission, not with this
one.

>> So why can't we re-use the existing interfaces instead of inventing a
>> new one?
> I'm unclear to what specifically you're referring -- the
> ioctl() used to retrieve the serial number in the guest?

Well, there's not specific ioctl to get a serial number for scsi, but
given that we now have SG_IO passthrough in virtio-blk it should be easy
enough to provide inquiry data and the device identification VPD page
by that way.  Not sure how it's handled for ide, maybe that way
is even easier.

  reply	other threads:[~2009-05-20  7:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13 17:06 [Qemu-devel] [PATCH 0/2] Add serial number support for virtio_blk, V2 john cooper
2009-05-18 12:13 ` [Qemu-devel] " Christoph Hellwig
2009-05-18 15:00   ` john cooper
2009-05-20  7:31     ` Christoph Hellwig [this message]
2009-05-20  7:36       ` Gleb Natapov
2009-05-27  0:26       ` john cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090520073129.GA17378@infradead.org \
    --to=hch@infradead.org \
    --cc=john.cooper@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).