From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M6gHG-0005GQ-Hk
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:31:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M6gHA-0005Es-Qu
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:31:48 -0400
Received: from [199.232.76.173] (port=33363 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M6gHA-0005Ep-Ji
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:31:44 -0400
Received: from mx20.gnu.org ([199.232.41.8]:11019)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from
	<BATV+4c438dd294ffa832e524+2096+infradead.org+hch@bombadil.srs.infradead.org>)
	id 1M6gHA-0002XB-8N
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:31:44 -0400
Received: from bombadil.infradead.org ([18.85.46.34])
	by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from
	<BATV+4c438dd294ffa832e524+2096+infradead.org+hch@bombadil.srs.infradead.org>)
	id 1M6gGy-0005yp-Bq
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:31:32 -0400
Date: Wed, 20 May 2009 03:31:29 -0400
From: Christoph Hellwig <hch@infradead.org>
Message-ID: <20090520073129.GA17378@infradead.org>
References: <4A0AFE31.70908@redhat.com> <20090518121325.GA32009@infradead.org>
	<4A117819.5060105@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A117819.5060105@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 0/2] Add serial number support for
	virtio_blk, V2
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: john cooper <john.cooper@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>

On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote:
> Christoph Hellwig wrote:
>> On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote:
>>> [Resend of earlier patch: 1/2 rebased to qemu-kvm,
>>> 2/2 minor tweak]
>>
>> patch 1/2 seems to be missing.
> It is in the kvm and qemu-devel list archives:
>
> http://www.spinics.net/lists/kvm/maillist.html
> http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00661.html

Ah, it got posted as reply to the previous submission, not with this
one.

>> So why can't we re-use the existing interfaces instead of inventing a
>> new one?
> I'm unclear to what specifically you're referring -- the
> ioctl() used to retrieve the serial number in the guest?

Well, there's not specific ioctl to get a serial number for scsi, but
given that we now have SG_IO passthrough in virtio-blk it should be easy
enough to provide inquiry data and the device identification VPD page
by that way.  Not sure how it's handled for ide, maybe that way
is even easier.