From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M6gMP-0006Ke-B1
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:37:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M6gMK-0006K9-Su
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:37:09 -0400
Received: from [199.232.76.173] (port=59700 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M6gMK-0006K6-O2
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:37:04 -0400
Received: from mx20.gnu.org ([199.232.41.8]:11397)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gleb@redhat.com>) id 1M6gMJ-0002sk-VY
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:37:04 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1M6gMI-0006Ii-Qk
	for qemu-devel@nongnu.org; Wed, 20 May 2009 03:37:03 -0400
Date: Wed, 20 May 2009 10:36:43 +0300
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20090520073643.GG12080@redhat.com>
References: <4A0AFE31.70908@redhat.com> <20090518121325.GA32009@infradead.org>
	<4A117819.5060105@redhat.com>
	<20090520073129.GA17378@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090520073129.GA17378@infradead.org>
Subject: [Qemu-devel] Re: [PATCH 0/2] Add serial number support for
	virtio_blk, V2
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@infradead.org>
Cc: john cooper <john.cooper@redhat.com>, qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>

On Wed, May 20, 2009 at 03:31:29AM -0400, Christoph Hellwig wrote:
> On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote:
> > Christoph Hellwig wrote:
> >> On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote:
> >>> [Resend of earlier patch: 1/2 rebased to qemu-kvm,
> >>> 2/2 minor tweak]
> >>
> >> patch 1/2 seems to be missing.
> > It is in the kvm and qemu-devel list archives:
> >
> > http://www.spinics.net/lists/kvm/maillist.html
> > http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00661.html
> 
> Ah, it got posted as reply to the previous submission, not with this
> one.
> 
> >> So why can't we re-use the existing interfaces instead of inventing a
> >> new one?
> > I'm unclear to what specifically you're referring -- the
> > ioctl() used to retrieve the serial number in the guest?
> 
> Well, there's not specific ioctl to get a serial number for scsi, but
> given that we now have SG_IO passthrough in virtio-blk it should be easy
> enough to provide inquiry data and the device identification VPD page
> by that way.  Not sure how it's handled for ide, maybe that way
> is even easier.
> 
IDE has "identify" command which return various info including 20 byte
serial number.

--
			Gleb.