From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6gpw-0006Zx-3j for qemu-devel@nongnu.org; Wed, 20 May 2009 04:07:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6gpr-0006X5-L1 for qemu-devel@nongnu.org; Wed, 20 May 2009 04:07:39 -0400 Received: from [199.232.76.173] (port=45193 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6gpr-0006X0-Du for qemu-devel@nongnu.org; Wed, 20 May 2009 04:07:35 -0400 Received: from mx20.gnu.org ([199.232.41.8]:13861) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M6gpq-0004oQ-RY for qemu-devel@nongnu.org; Wed, 20 May 2009 04:07:35 -0400 Received: from verein.lst.de ([213.95.11.210]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M6gpo-0008KV-QQ for qemu-devel@nongnu.org; Wed, 20 May 2009 04:07:33 -0400 Date: Wed, 20 May 2009 10:07:23 +0200 From: Christoph Hellwig Message-ID: <20090520080723.GA2957@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] block/raw-posix.c:hdev_create() on FreeBSD and in general List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: nolan@sigbus.net, qemu-devel@nongnu.org Didn't FreeBSD do away with block device nodes in the 4.x release cycle? In that case we will never allow to create host devices on FreeBSD with this code. Also I think we should allow creating the host devices on all supported operating systems. For Linux we should use block devices, for FreeBSD always char devices. For the other BSDs and Solaris do we allow only block or also the raw char devices? Not sure if they actually support O_DIRECT for block devices nodes which pretty much is a Linux-ism so for cache=none at least we should probably open the raw nodes..