From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M79pY-0004oY-Td
	for qemu-devel@nongnu.org; Thu, 21 May 2009 11:05:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M79pU-0004mQ-5L
	for qemu-devel@nongnu.org; Thu, 21 May 2009 11:05:12 -0400
Received: from [199.232.76.173] (port=51236 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M79pU-0004lG-0Z
	for qemu-devel@nongnu.org; Thu, 21 May 2009 11:05:08 -0400
Received: from mx1.redhat.com ([66.187.233.31]:56796)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <berrange@redhat.com>) id 1M79pR-0001wY-7h
	for qemu-devel@nongnu.org; Thu, 21 May 2009 11:05:05 -0400
Date: Thu, 21 May 2009 16:04:57 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] augment info migrate with page status
Message-ID: <20090521150457.GD10055@redhat.com>
References: <1242861605-12844-1-git-send-email-glommer@redhat.com>
	<20090521140504.GA10055@redhat.com> <4A156C02.5050604@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A156C02.5050604@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, May 21, 2009 at 05:58:10PM +0300, Avi Kivity wrote:
> Daniel P. Berrange wrote:
> >On Wed, May 20, 2009 at 07:20:05PM -0400, Glauber Costa wrote:
> >  
> >>This patch augments info migrate output with status about:
> >>* pages remaining
> >>* pages transferred
> >>    
> >
> >Could you add 'pages total' and/or possibly 'page size', so apps 
> >using this can more easily do calculations, without having to worry
> >about hardcoding page sizes for each architecture they deal with. 
> >
> >Oh, what happens if the guest is backed by huge pages ? Does the
> >'pages transferred' always count in terms of 4k pages, even if
> >2 M & 1 GB pages are in use ?
> >  
> 
> We should just use bytes.  I don't see how backing page size matters.

That works for me, because ultimately bytes is what I'd want at libvirt
layer. 

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|