From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7AjH-0002aU-A1
	for qemu-devel@nongnu.org; Thu, 21 May 2009 12:02:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7AjC-0002XN-G2
	for qemu-devel@nongnu.org; Thu, 21 May 2009 12:02:46 -0400
Received: from [199.232.76.173] (port=53770 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7AjC-0002XA-6w
	for qemu-devel@nongnu.org; Thu, 21 May 2009 12:02:42 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48812)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1M7AjB-0002Yb-Ib
	for qemu-devel@nongnu.org; Thu, 21 May 2009 12:02:41 -0400
Date: Thu, 21 May 2009 13:07:50 -0300
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] augment info migrate with page status
Message-ID: <20090521160750.GC24584@poweredge.glommer>
References: <1242861605-12844-1-git-send-email-glommer@redhat.com>
	<20090521140504.GA10055@redhat.com> <4A156C02.5050604@redhat.com>
	<20090521150457.GD10055@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090521150457.GD10055@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: aliguori@us.ibm.com, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Thu, May 21, 2009 at 04:04:57PM +0100, Daniel P. Berrange wrote:
> On Thu, May 21, 2009 at 05:58:10PM +0300, Avi Kivity wrote:
> > Daniel P. Berrange wrote:
> > >On Wed, May 20, 2009 at 07:20:05PM -0400, Glauber Costa wrote:
> > >  
> > >>This patch augments info migrate output with status about:
> > >>* pages remaining
> > >>* pages transferred
> > >>    
> > >
> > >Could you add 'pages total' and/or possibly 'page size', so apps 
> > >using this can more easily do calculations, without having to worry
> > >about hardcoding page sizes for each architecture they deal with. 
> > >
> > >Oh, what happens if the guest is backed by huge pages ? Does the
> > >'pages transferred' always count in terms of 4k pages, even if
> > >2 M & 1 GB pages are in use ?
> > >  
> > 
> > We should just use bytes.  I don't see how backing page size matters.
> 
> That works for me, because ultimately bytes is what I'd want at libvirt
> layer. 
agreed.