From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7GWR-0000cu-5U
	for qemu-devel@nongnu.org; Thu, 21 May 2009 18:13:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7GWL-0000c4-V9
	for qemu-devel@nongnu.org; Thu, 21 May 2009 18:13:54 -0400
Received: from [199.232.76.173] (port=46476 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7GWL-0000bp-LM
	for qemu-devel@nongnu.org; Thu, 21 May 2009 18:13:49 -0400
Received: from mx2.redhat.com ([66.187.237.31]:59618)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1M7GWL-0007Rl-9O
	for qemu-devel@nongnu.org; Thu, 21 May 2009 18:13:49 -0400
Date: Thu, 21 May 2009 19:19:02 -0300
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20090521221902.GF24584@poweredge.glommer>
References: <1242930079-19798-1-git-send-email-glommer@redhat.com>
	<4A15CE70.7030201@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A15CE70.7030201@us.ibm.com>
Subject: [Qemu-devel] Re: [PATCH] run vnc without sdl
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

On Thu, May 21, 2009 at 04:58:08PM -0500, Anthony Liguori wrote:
> Glauber Costa wrote:
>> commit f92f8afebe038a4eae9ad90a140c9529f94919a6
>> "Eliminate --disable-gfx-check and make VNC default when SDL not available"
>> broke usage of vnc. Passing -vnc <something> now fails because it cannot initialize
>> SDL.
>>
>> Signed-off-by: Glauber Costa <glommer@redhat.com>
>>   
>
> What do you think about the attached?  My goal with the original  
> refactoring was to more cleanly separate things that's why I didn't want  
> to introduce the !vnc_display.
>
> Ideally, we could make the various display states register themselves  
> and completely eliminate the #ifdefs...
works for me.