From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7GoR-0001eT-8K for qemu-devel@nongnu.org; Thu, 21 May 2009 18:32:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7GoM-0001c6-GB for qemu-devel@nongnu.org; Thu, 21 May 2009 18:32:30 -0400 Received: from [199.232.76.173] (port=57641 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7GoM-0001bv-BI for qemu-devel@nongnu.org; Thu, 21 May 2009 18:32:26 -0400 Received: from mx20.gnu.org ([199.232.41.8]:28423) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M7GoM-0002pu-3y for qemu-devel@nongnu.org; Thu, 21 May 2009 18:32:26 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M7GoL-0005Wx-04 for qemu-devel@nongnu.org; Thu, 21 May 2009 18:32:25 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once Date: Thu, 21 May 2009 23:32:19 +0100 References: <200905211555.n4LFtklw030900@d01av03.pok.ibm.com> <4A158541.8000209@web.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905212332.20605.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Jan Kiszka > > This breaks archs that do not come with DMA_* implementations. At least > > ARM no longer links. > > > > LINK arm-softmmu/qemu-system-arm > > ../libhw64/libqemuhw64.a(fdc.o): In function `fdctrl_stop_transfer': > > /data/qemu/hw/fdc.c:1086: undefined reference to `DMA_release_DREQ' > > [...] > > Yes, I forgot about the whole-archive hack. I've disabled it for > hwlib, so now arm-softmmu links. This is completely wrong. The reason we use whole-archive is so that device constructors are run. Most machines are broken after your change. Paul