From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7X0F-0006d6-3B for qemu-devel@nongnu.org; Fri, 22 May 2009 11:49:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7X09-0006au-J8 for qemu-devel@nongnu.org; Fri, 22 May 2009 11:49:45 -0400 Received: from [199.232.76.173] (port=52597 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7X09-0006ag-At for qemu-devel@nongnu.org; Fri, 22 May 2009 11:49:41 -0400 Received: from mx20.gnu.org ([199.232.41.8]:22373) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M7X08-0008RJ-Vq for qemu-devel@nongnu.org; Fri, 22 May 2009 11:49:41 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M7X07-00017u-Mw for qemu-devel@nongnu.org; Fri, 22 May 2009 11:49:40 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once Date: Fri, 22 May 2009 16:49:37 +0100 References: <200905211555.n4LFtklw030900@d01av03.pok.ibm.com> <200905212332.20605.paul@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905221649.37462.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Jan Kiszka > > > Yes, I forgot about the whole-archive hack. I've disabled it for > > > hwlib, so now arm-softmmu links. > > > > This is completely wrong. The reason we use whole-archive is so that > > device constructors are run. Most machines are broken after your change. > > Did you test? I don't see any breakage, qemu-img --help shows all > block formats and qemu-system-arm -M '?' lists all machines. > > Because whole-archive is still used for libqemu_common.a, all devices > in that archive are linked in (whether they are used or not!), so the > constructors work. The machines themselves are there, but many of the devices they use (e.g. the pci scsi emulation) are not. Paul