From: Vincent Sanders <vince@kyllikki.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/15] S3C system on chip integrated peripheral device state header
Date: Sat, 23 May 2009 17:39:14 +0100 [thread overview]
Message-ID: <20090523163914.GB8037@derik> (raw)
In-Reply-To: <20090515223312.GM16288@game.jcrosoft.org>
On Sat, May 16, 2009 at 12:33:12AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > + uint32_t tclk1; /* second timer clock source frequency */
> > +
> > + /* GPIO block */
> > + uint32_t gpio_reg[47];
> > +
> > + /* Realtime clock */
> > + uint8_t rtc_reg[19];
> > +
> > + /* i2c */
> > + struct s3c24xx_i2c_state_s *iic;
> > +
> > + /* Timers, (Specifically timer4) */
> > + uint32_t timers_reg[17];
> it will be better to define a struct with the timers_reg content
> same with the other arry
I had a good hard look at this and decided you were right. I have
restructured all the SOC devices to be completely self contained. I
just posted the new series against git head, it looks a fair bit
neater.
--
Regards Vincent
http://www.kyllikki.org/
next prev parent reply other threads:[~2009-05-23 16:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 8:44 [Qemu-devel] Add ARM S3C SOC core, drivers and boards Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 01/15] Add ARM 920T CPU identifier Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 02/15] S3C system on chip integrated peripheral device state header Vincent Sanders
2009-05-15 22:33 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 16:39 ` Vincent Sanders [this message]
2009-05-06 8:44 ` [Qemu-devel] [PATCH 03/15] Peripheral driver for S3C SOC SDRAM controller Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 04/15] Peripheral driver for S3C SOC IRQ controller Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 05/15] Peripheral driver for S3C SOC clock control Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 06/15] Peripheral driver for S3C SOC timers Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 07/15] Peripheral driver for S3C SOC Serial ports Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 08/15] Peripheral driver for S3C SOC real time clock Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 09/15] Peripheral driver for S3C SOC general purpose I/O Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 10/15] Peripheral driver for S3C SOC I2C controller Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 11/15] Peripheral driver for S3C SOC LCD controller Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 12/15] Peripheral driver for S3C SOC NAND controller Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 13/15] S3C2410 SOC implementation using S3C peripheral blocks Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 14/15] S3C2440 Implementation using S3C periperals Vincent Sanders
2009-05-06 8:44 ` [Qemu-devel] [PATCH 15/15] Add bast and smdk2410 boards which use S3C2410 SOC Vincent Sanders
2009-05-14 12:35 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-15 9:41 ` Vincent Sanders
2009-05-15 19:52 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-15 20:29 ` Ben Dooks
2009-05-14 8:58 ` [Qemu-devel] Add ARM S3C SOC core, drivers and boards Vincent Sanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090523163914.GB8037@derik \
--to=vince@kyllikki.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).