From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>, Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [Qemu-devel] [PATCH] kvm: Mark full address range dirty on live migration start
Date: Sun, 24 May 2009 19:23:49 +0100 [thread overview]
Message-ID: <200905241923.50218.paul@codesourcery.com> (raw)
In-Reply-To: <20090523134716.GB26811@poweredge.glommer>
On Saturday 23 May 2009, Glauber Costa wrote:
> On Fri, May 22, 2009 at 11:51:45PM +0200, Jan Kiszka wrote:
> > As Avi correctly noted, last_ram_offset does not mark the last physical
> > RAM address the guest may see (due to non-continuous memory regions).
> > Ensure that we catch them all by marking the full possible address range
> > dirty.
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Indeed, we already do something in that lines in qemu-kvm tree,
> in a place that does not apply for It makes a lot of sense. Just
> maybe you could just -1UL instead of defining a new constant, but I don't
> really care.
-1ul is wrong. -1 is correct.
Paul
prev parent reply other threads:[~2009-05-24 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 21:51 [Qemu-devel] [PATCH] kvm: Mark full address range dirty on live migration start Jan Kiszka
2009-05-23 13:47 ` Glauber Costa
2009-05-23 13:47 ` Jan Kiszka
2009-05-24 18:23 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905241923.50218.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).