From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M8ITn-0003Ns-R2 for qemu-devel@nongnu.org; Sun, 24 May 2009 14:31:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M8ITi-0003LG-Vx for qemu-devel@nongnu.org; Sun, 24 May 2009 14:31:27 -0400 Received: from [199.232.76.173] (port=49280 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M8ITi-0003LB-Px for qemu-devel@nongnu.org; Sun, 24 May 2009 14:31:22 -0400 Received: from mx20.gnu.org ([199.232.41.8]:59902) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8ITi-0000Zg-FQ for qemu-devel@nongnu.org; Sun, 24 May 2009 14:31:22 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M8ITh-0002tK-Lm for qemu-devel@nongnu.org; Sun, 24 May 2009 14:31:22 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers Date: Sun, 24 May 2009 19:31:19 +0100 References: <20090423171503.GC4629@derik> <200904301708.01385.paul@codesourcery.com> <20090523165033.GC8037@derik> In-Reply-To: <20090523165033.GC8037@derik> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905241931.19368.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Vincent Sanders On Saturday 23 May 2009, Vincent Sanders wrote: > On Thu, Apr 30, 2009 at 05:08:01PM +0100, Paul Brook wrote: > > > env->cp15.c0_cpuid = id; > > > switch (id) { > > > + case ARM_CPUID_ARM920T: > > > + break; > > > > This is woefully incomplete. At minimum it needs a comment describing how > > this is a lie. > > I have worked out what you meant was that the copro 15 registers > needed configuring appropriately in this case. More fundamental than that. We emulate armv5te. The arm920t is armv4t. i.e. even usermode code may not work right. Paul