From: Riku Voipio <riku.voipio@iki.fi>
To: vibi sreenivasan <vibi_sreenivasan@cms.com>
Cc: Martin Mohring <martin.mohring@opensuse.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/02] linux-user : add vmsplice system call
Date: Mon, 25 May 2009 17:04:54 +0300 [thread overview]
Message-ID: <20090525140454.GA6014@kos.to> (raw)
In-Reply-To: <1243231987.2177.7.camel@system>
On Mon, May 25, 2009 at 11:43:07AM +0530, vibi sreenivasan wrote:
> hi,
> Thanks for your comment.
> > fine that you provide missing syscalls for user mode one after the other.
> >
> > I have one remark: if the host os kernel is too old to provide the
> > syscalls, they should be #if'ed out (tee, vmsplice & co).
> if the host kernel is too old , i think it will return -1 & set errno to
> ENOSYS.
> So isnt that same as putting #ifdef.
Yes, having old kernel is not a problem in this. However, having a
old libc when compiling qemu can be a problem. Think Redhat RHEL 4
or debian etch. vmsplice() is not available, and compiling qemu
would fail.
See how we #ifdef utimensat in linux-user/syscall.c and detect
availability in ./configure
Other than that, your patches looked ok.
> > Or even emulate the syscall - which can be quite hard.
> Hmm thinking on that. will it be worth?
This could be in interest for people who want to run qemu linux-user
on non-linux systems (such a *bsd). But that doesn't work yet,
and even when people get it working, new syscalls such as tee/splice
are not the most important ones to provide emulation for. Very
few applications use these syscalls yet.
prev parent reply other threads:[~2009-05-25 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 8:05 [Qemu-devel] [PATCH 02/02] linux-user : add vmsplice system call vibi sreenivasan
2009-05-24 18:21 ` Martin Mohring
2009-05-25 6:13 ` vibi sreenivasan
2009-05-25 14:04 ` Riku Voipio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525140454.GA6014@kos.to \
--to=riku.voipio@iki.fi \
--cc=martin.mohring@opensuse.org \
--cc=qemu-devel@nongnu.org \
--cc=vibi_sreenivasan@cms.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).