From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M8anV-0005ez-Au
	for qemu-devel@nongnu.org; Mon, 25 May 2009 10:05:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M8anT-0005cx-NT
	for qemu-devel@nongnu.org; Mon, 25 May 2009 10:05:00 -0400
Received: from [199.232.76.173] (port=52188 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M8anT-0005cU-AC
	for qemu-devel@nongnu.org; Mon, 25 May 2009 10:04:59 -0400
Received: from naru.obs2.net ([84.20.150.76]:36335)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1M8anS-0003km-Ke
	for qemu-devel@nongnu.org; Mon, 25 May 2009 10:04:58 -0400
Date: Mon, 25 May 2009 17:04:54 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH 02/02] linux-user : add vmsplice system call
Message-ID: <20090525140454.GA6014@kos.to>
References: <1243152335.2111.9.camel@system> <4A199013.10001@opensuse.org>
	<1243231987.2177.7.camel@system>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1243231987.2177.7.camel@system>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: vibi sreenivasan <vibi_sreenivasan@cms.com>
Cc: Martin Mohring <martin.mohring@opensuse.org>, qemu-devel@nongnu.org

On Mon, May 25, 2009 at 11:43:07AM +0530, vibi sreenivasan wrote:
> hi,
> 	Thanks for your comment.
> > fine that you provide missing syscalls for user mode one after the other.
> > 
> > I have one remark: if the host os kernel is too old to provide the
> > syscalls, they should be #if'ed out (tee, vmsplice & co).
> if the host kernel is too old , i think it will return -1 & set errno to
> ENOSYS.
> So isnt that same as putting #ifdef.

Yes, having old kernel is not a problem in this. However, having a
old libc when compiling qemu can be a problem. Think Redhat RHEL 4
or debian etch. vmsplice() is not available, and compiling qemu
would fail.

See how we #ifdef utimensat in linux-user/syscall.c and detect
availability in ./configure

Other than that, your patches looked ok.
 
> > Or even emulate the syscall - which can be quite hard.

> Hmm thinking on that. will it be worth?

This could be in interest for people who want to run qemu linux-user
on non-linux systems (such a *bsd). But that doesn't work yet,
and even when people get it working, new syscalls such as tee/splice
are not the most important ones to provide emulation for. Very
few applications use these syscalls yet.