From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M8qPw-0001yU-05
	for qemu-devel@nongnu.org; Tue, 26 May 2009 02:45:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M8qPq-0001tP-Cn
	for qemu-devel@nongnu.org; Tue, 26 May 2009 02:45:42 -0400
Received: from [199.232.76.173] (port=40111 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M8qPq-0001tL-AH
	for qemu-devel@nongnu.org; Tue, 26 May 2009 02:45:38 -0400
Received: from mx20.gnu.org ([199.232.41.8]:57634)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <mst@redhat.com>) id 1M8qPp-0006nh-PL
	for qemu-devel@nongnu.org; Tue, 26 May 2009 02:45:38 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1M8qPo-0001Vx-PO
	for qemu-devel@nongnu.org; Tue, 26 May 2009 02:45:37 -0400
Date: Tue, 26 May 2009 09:41:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.
Message-ID: <20090526064152.GH6856@redhat.com>
References: <cover.1243253205.git.mst@redhat.com>
	<20090525122533.GE5046@redhat.com>
	<20090526023337.GF13076%yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090526023337.GF13076%yamahata@valinux.co.jp>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>

On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote:
> On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote:
> > Add inline routines for convenient access to pci devices
> > with correct (little) endianness. Will be used by MSI-X support.
>
> Just a minor comment.
> How about to add pci_[sg]et_byte() for consistency?

I don't see that it makes sense - pci_set_long(config, value)
is shorter than *((uint32_t *)config) = cpu_to_le32(value),
but single bytes don't have endianness, and *config = value
is shorter.

-- 
MST