From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M8tlt-0008Vt-MY
	for qemu-devel@nongnu.org; Tue, 26 May 2009 06:20:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M8tlp-0008Us-Jr
	for qemu-devel@nongnu.org; Tue, 26 May 2009 06:20:37 -0400
Received: from [199.232.76.173] (port=38179 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M8tlp-0008Ul-Cp
	for qemu-devel@nongnu.org; Tue, 26 May 2009 06:20:33 -0400
Received: from mx20.gnu.org ([199.232.41.8]:10035)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1M8tlp-0001v0-5H
	for qemu-devel@nongnu.org; Tue, 26 May 2009 06:20:33 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1M8tlo-0000JS-Fn
	for qemu-devel@nongnu.org; Tue, 26 May 2009 06:20:32 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Tue, 26 May 2009 11:20:29 +0100
References: <20090525133405.GA6166@redhat.com> <4A1BA998.8040803@codemonkey.ws>
In-Reply-To: <4A1BA998.8040803@codemonkey.ws>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905261120.30344.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [PATCH] qemu: virtio save/load bindings
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Avi Kivity <avi@redhat.com>

> > -    /* FIXME: load/save binding.  */
> > -    //pci_device_save(&vdev->pci_dev, f);
> > -    //msix_save(&vdev->pci_dev, f);
>
> qdev regressed save/restore?  What else is broken right now from the
> qdev commit?
>
> I'm beginning to think committing in the state it was in was a mistake.
> Paul, can you put together a TODO so that we know all of the things that
> have regressed so we can get things back into shape?

Sorry, this one apparently slipped past. I#'d intended to fix it, but 
apparently never ported that bit of the patch.

Paul