From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M92n9-00045v-Dz for qemu-devel@nongnu.org; Tue, 26 May 2009 15:58:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M92n4-00045R-2w for qemu-devel@nongnu.org; Tue, 26 May 2009 15:58:30 -0400 Received: from [199.232.76.173] (port=54158 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M92n3-00045O-So for qemu-devel@nongnu.org; Tue, 26 May 2009 15:58:25 -0400 Received: from mx1.redhat.com ([66.187.233.31]:44231) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M92n3-0006wv-Fi for qemu-devel@nongnu.org; Tue, 26 May 2009 15:58:25 -0400 Date: Tue, 26 May 2009 20:58:19 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images Message-ID: <20090526195819.GD13938@redhat.com> References: <4A16D5B8.50508@codemonkey.ws> <4A1BA22D.4040008@codemonkey.ws> <4A1BB1DE.3080600@redhat.com> <4A1C487B.90908@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A1C487B.90908@codemonkey.ws> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Aaron Mason , "qemu-devel@nongnu.org" On Tue, May 26, 2009 at 02:52:27PM -0500, Anthony Liguori wrote: > Kevin Wolf wrote: > > >FWIW, I know that SUSE had a use for these SCSI VMDKs and they carry a > >local patch for it. I would prefer to have such things upstream, even if > >it's just for exporting. After all, qemu-img is the Swiss army knife for > >images. > > > > If there's support for it, we can take it. I worry about adding > features that aren't widely useful as they add complexity and make it > hard to refactor things. > > Introducing BLOCK_FLAG_BUSLOGIC and BLOCK_FLAG_LSILOGIC seems very wrong > to me. You're happy with it? I think the addition of new VMDK specific flags to qemu-img is pretty wrong too - " create [-e] [-6] [-b base_image] [-f fmt] filename [size]\n" + " create [-e] [-6] [-S] [-L] [-b base_image] [-f fmt] filename .... + " '-S' indicates that the target image must be a BusLogic SCSI virtual disk (vmdk format only)\n" + " '-L' indicates that the target image must be a LSI Logic SCSI virtual disk (vmdk format only)\n" If we want to expose this capability, then I think we should have some kind of generic 'feature' string that can be passed through to the specific block driver, without needing an unbounded number of qemu-img args to be added. eg. qemu-img create -o target=buslogic foo.vmdk qemu-img create -o target=lsilogic foo.vmdk And just pass the whole value from '-o' through to the block layer's create method. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|