From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Aaron Mason <absorbentshoulderman@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images
Date: Wed, 27 May 2009 09:40:41 +0200 [thread overview]
Message-ID: <20090527074041.GA7356@lst.de> (raw)
In-Reply-To: <4A1CEBCC.5000307@redhat.com>
On Wed, May 27, 2009 at 09:29:16AM +0200, Kevin Wolf wrote:
> No, I'm not happy with this particular patch, especially given that it
> doesn't apply to master any more. ;-)
>
> You said this was "not useful", so I'm just talking of the
> functionality, independent of the code. And code-wise, it really should
> be only a few lines to vmdk - which makes the create function longer by
> maybe five lines, but hardly more complex.
Exactly my though. Rebased ontop of Kevin's option rework this is
pretty trivial and useful enough to put it in.
Aaron, can you rebase this to the lastest git tree?
next prev parent reply other threads:[~2009-05-27 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 10:29 [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images Aaron Mason
2009-05-22 16:41 ` Anthony Liguori
[not found] ` <e869674d0905240116n3245c5bdxf66552984a4037f5@mail.gmail.com>
2009-05-26 8:02 ` Anthony Liguori
2009-05-26 9:09 ` Kevin Wolf
2009-05-26 19:52 ` Anthony Liguori
2009-05-26 19:58 ` Daniel P. Berrange
2009-05-26 20:01 ` Anthony Liguori
2009-05-27 7:29 ` Kevin Wolf
2009-05-27 7:40 ` Christoph Hellwig [this message]
2009-05-27 8:23 ` Anthony Liguori
2009-05-26 18:17 ` Robert Riebisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527074041.GA7356@lst.de \
--to=hch@lst.de \
--cc=absorbentshoulderman@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).