From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9Dkr-0001u6-Lb for qemu-devel@nongnu.org; Wed, 27 May 2009 03:40:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9Dkn-0001q4-66 for qemu-devel@nongnu.org; Wed, 27 May 2009 03:40:53 -0400 Received: from [199.232.76.173] (port=34691 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9Dkn-0001q1-0f for qemu-devel@nongnu.org; Wed, 27 May 2009 03:40:49 -0400 Received: from mx20.gnu.org ([199.232.41.8]:28263) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9Dkm-0005Zh-IL for qemu-devel@nongnu.org; Wed, 27 May 2009 03:40:48 -0400 Received: from verein.lst.de ([213.95.11.210]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9Dkk-0006z0-Hb for qemu-devel@nongnu.org; Wed, 27 May 2009 03:40:46 -0400 Date: Wed, 27 May 2009 09:40:41 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images Message-ID: <20090527074041.GA7356@lst.de> References: <4A16D5B8.50508@codemonkey.ws> <4A1BA22D.4040008@codemonkey.ws> <4A1BB1DE.3080600@redhat.com> <4A1C487B.90908@codemonkey.ws> <4A1CEBCC.5000307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A1CEBCC.5000307@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Aaron Mason , "qemu-devel@nongnu.org" On Wed, May 27, 2009 at 09:29:16AM +0200, Kevin Wolf wrote: > No, I'm not happy with this particular patch, especially given that it > doesn't apply to master any more. ;-) > > You said this was "not useful", so I'm just talking of the > functionality, independent of the code. And code-wise, it really should > be only a few lines to vmdk - which makes the create function longer by > maybe five lines, but hardly more complex. Exactly my though. Rebased ontop of Kevin's option rework this is pretty trivial and useful enough to put it in. Aaron, can you rebase this to the lastest git tree?