From: Christoph Hellwig <hch@lst.de>
To: john cooper <john.cooper@redhat.com>
Cc: qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add serial number support for virtio_blk, V3
Date: Wed, 27 May 2009 09:51:33 +0200 [thread overview]
Message-ID: <20090527075133.GA7795@lst.de> (raw)
In-Reply-To: <4A1C88CD.2090406@redhat.com>
Looks good to me. In a couple of places you have spaces beforing
the opening brace as in:
+ memcpy(&blkcfg.serial, s->serial_str, sizeof (blkcfg.serial));
which is not the style used in the surrounding code, I'd suggest
removing them.
prev parent reply other threads:[~2009-05-27 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:26 [Qemu-devel] [PATCH 1/2] Add serial number support for virtio_blk, V3 john cooper
2009-05-27 7:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527075133.GA7795@lst.de \
--to=hch@lst.de \
--cc=john.cooper@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).