From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M9DvI-0005Oi-L1
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:51:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M9DvE-0005N4-2m
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:51:40 -0400
Received: from [199.232.76.173] (port=53221 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M9DvD-0005Mu-T9
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:51:35 -0400
Received: from mx20.gnu.org ([199.232.41.8]:29275)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <hch@lst.de>) id 1M9DvD-0008Rn-6I
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:51:35 -0400
Received: from verein.lst.de ([213.95.11.210])
	by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from <hch@lst.de>)
	id 1M9DvC-0007jh-A9
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:51:34 -0400
Date: Wed, 27 May 2009 09:51:33 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add serial number support for virtio_blk,
	V3
Message-ID: <20090527075133.GA7795@lst.de>
References: <4A1C88CD.2090406@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A1C88CD.2090406@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: john cooper <john.cooper@redhat.com>
Cc: qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>

Looks good to me.  In a couple of places you have spaces beforing
the opening brace as in:

+    memcpy(&blkcfg.serial, s->serial_str, sizeof (blkcfg.serial));

which is not the style used in the surrounding code, I'd suggest
removing them.