From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M9Dxp-0006C3-IP
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:54:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M9Dxk-0006AO-NQ
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:54:16 -0400
Received: from [199.232.76.173] (port=53245 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M9Dxk-0006AE-Ft
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:54:12 -0400
Received: from mx20.gnu.org ([199.232.41.8]:29479)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <hch@lst.de>) id 1M9Dxj-0000GK-R6
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:54:12 -0400
Received: from verein.lst.de ([213.95.11.210])
	by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from <hch@lst.de>)
	id 1M9Dxi-0007uV-VI
	for qemu-devel@nongnu.org; Wed, 27 May 2009 03:54:11 -0400
Date: Wed, 27 May 2009 09:54:09 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk,
	V3
Message-ID: <20090527075409.GA7926@lst.de>
References: <4A1C88DE.6050608@redhat.com> <20090527074919.GB7356@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090527074919.GB7356@lst.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: john cooper <john.cooper@redhat.com>
Cc: rusty@rustcorp.com.au, qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>

On Wed, May 27, 2009 at 09:49:19AM +0200, Christoph Hellwig wrote:
> /*
>  * IDE-compatible identify ioctl.
>  *
>  * Currenlyt only returns the serial number and leaves all other fields
>  * zero.
>  */

Btw, thinking about it the rest of the information in the ioctl should
probably be filled up with faked data, similar to how we do it for
the ide emulation inside qemu.