From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@lst.de>
Cc: john cooper <john.cooper@redhat.com>,
qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3
Date: Wed, 27 May 2009 22:23:26 +0930 [thread overview]
Message-ID: <200905272223.27614.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090527074919.GB7356@lst.de>
On Wed, 27 May 2009 05:19:19 pm Christoph Hellwig wrote:
> You should probably include rusty as he's collecting the patches
> for the virtio guest drivers.
Yes. It *does* help to cc the maintainer if you want your patches applied :)
And I particularly love untested code like this!
> + if (!(id = kzalloc(ATA_ID_WORDS, GFP_KERNEL)))
> + rv = -ENOMEM;
Doesn't ATA_ID_WORDS seem like a strange name for a number of bytes?
What's this *for* BTW?
Rusty.
next prev parent reply other threads:[~2009-05-28 3:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:27 [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3 john cooper
2009-05-27 7:49 ` Christoph Hellwig
2009-05-27 7:54 ` Christoph Hellwig
2009-05-29 4:04 ` john cooper
2009-05-27 12:53 ` Rusty Russell [this message]
2009-05-29 4:05 ` john cooper
2009-05-27 15:06 ` john cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905272223.27614.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=hch@lst.de \
--cc=john.cooper@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).