From: Glauber Costa <glommer@redhat.com>
To: Tomasz Chmielewski <mangoo@wpkg.org>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Disable kqemu by default
Date: Fri, 29 May 2009 09:30:47 -0300 [thread overview]
Message-ID: <20090529123047.GI30777@poweredge.glommer> (raw)
In-Reply-To: <4A1FD397.9040904@wpkg.org>
On Fri, May 29, 2009 at 02:22:47PM +0200, Tomasz Chmielewski wrote:
> Glauber Costa wrote:
>> turns -no-kqemu option into -kqemu
>> set kqemu_allowed to 0 by default.
>
> (...)
>
>> #ifdef CONFIG_KQEMU
>> -DEF("no-kqemu", 0, QEMU_OPTION_no_kqemu, \
>> - "-no-kqemu disable KQEMU kernel module usage\n")
>> +DEF("-kqemu", 0, QEMU_OPTION_kqemu, \
>> + "-kqemu enable KQEMU kernel module usage\n")
>
> Why is this change needed?
Well, we certainly need a -kqemu option to enable it, if it is disabled by default.
>
> Even if changed, wouldn't it be better to leave the -no-kqemu option for
> compatibility reasons? Otherwise, current scripts may break.
options comes and go every day.
but it's not a big burden, we can leave the old option around...
next prev parent reply other threads:[~2009-05-29 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 12:11 [Qemu-devel] [PATCH] Disable kqemu by default Glauber Costa
2009-05-29 12:22 ` Tomasz Chmielewski
2009-05-29 12:30 ` Glauber Costa [this message]
2009-05-29 12:31 ` Tomasz Chmielewski
2009-05-29 13:18 ` Glauber Costa
2009-05-30 17:35 ` François Revol
2009-05-29 12:40 ` Daniel P. Berrange
2009-05-30 8:06 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529123047.GI30777@poweredge.glommer \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mangoo@wpkg.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).