From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MA19F-0002NC-KP
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:25:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MA19B-0002Lh-KX
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:25:21 -0400
Received: from [199.232.76.173] (port=55650 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MA19B-0002Lb-Cw
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:25:17 -0400
Received: from mx2.redhat.com ([66.187.237.31]:50228)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1MA19A-0003s9-PG
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:25:17 -0400
Date: Fri, 29 May 2009 09:30:47 -0300
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Disable kqemu by default
Message-ID: <20090529123047.GI30777@poweredge.glommer>
References: <1243599100-3866-1-git-send-email-glommer@redhat.com>
	<4A1FD397.9040904@wpkg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A1FD397.9040904@wpkg.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomasz Chmielewski <mangoo@wpkg.org>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, May 29, 2009 at 02:22:47PM +0200, Tomasz Chmielewski wrote:
> Glauber Costa wrote:
>> turns -no-kqemu option into -kqemu
>> set kqemu_allowed to 0 by default.
>
> (...)
>
>>  #ifdef CONFIG_KQEMU
>> -DEF("no-kqemu", 0, QEMU_OPTION_no_kqemu, \
>> -    "-no-kqemu       disable KQEMU kernel module usage\n")
>> +DEF("-kqemu", 0, QEMU_OPTION_kqemu, \
>> +    "-kqemu          enable KQEMU kernel module usage\n")
>
> Why is this change needed?
Well, we certainly need a -kqemu option to enable it, if it is disabled by default.

>
> Even if changed, wouldn't it be better to leave the -no-kqemu option for  
> compatibility reasons? Otherwise, current scripts may break.
options comes and go every day.

but it's not a big burden, we can leave the old option around...