From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MA1OI-0007ia-13
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:40:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MA1OD-0007cq-7S
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:40:53 -0400
Received: from [199.232.76.173] (port=37291 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MA1OC-0007cY-Ta
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:40:48 -0400
Received: from mx1.redhat.com ([66.187.233.31]:35776)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <berrange@redhat.com>) id 1MA1OC-0007f4-Fn
	for qemu-devel@nongnu.org; Fri, 29 May 2009 08:40:48 -0400
Date: Fri, 29 May 2009 13:40:44 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Disable kqemu by default
Message-ID: <20090529124044.GI29375@redhat.com>
References: <1243599100-3866-1-git-send-email-glommer@redhat.com>
	<4A1FD397.9040904@wpkg.org>
	<20090529123047.GI30777@poweredge.glommer>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090529123047.GI30777@poweredge.glommer>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, Tomasz Chmielewski <mangoo@wpkg.org>, qemu-devel@nongnu.org

On Fri, May 29, 2009 at 09:30:47AM -0300, Glauber Costa wrote:
> On Fri, May 29, 2009 at 02:22:47PM +0200, Tomasz Chmielewski wrote:
> > Glauber Costa wrote:
> >> turns -no-kqemu option into -kqemu
> >> set kqemu_allowed to 0 by default.
> >
> > (...)
> >
> >>  #ifdef CONFIG_KQEMU
> >> -DEF("no-kqemu", 0, QEMU_OPTION_no_kqemu, \
> >> -    "-no-kqemu       disable KQEMU kernel module usage\n")
> >> +DEF("-kqemu", 0, QEMU_OPTION_kqemu, \
> >> +    "-kqemu          enable KQEMU kernel module usage\n")
> >
> > Why is this change needed?
> Well, we certainly need a -kqemu option to enable it, if it is disabled by default.
> 
> >
> > Even if changed, wouldn't it be better to leave the -no-kqemu option for  
> > compatibility reasons? Otherwise, current scripts may break.
> options comes and go every day.
> 
> but it's not a big burden, we can leave the old option around...

How about we add an option that's more future proof.

eg, 

     --accel  qemu|kvm|kqemu|xen

if that isn't given, then it'd pick the 'best', use --accel XXX to
override the auto behaviour

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|