From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MA48I-0008WA-NQ
	for qemu-devel@nongnu.org; Fri, 29 May 2009 11:36:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MA48E-0008Qj-7Z
	for qemu-devel@nongnu.org; Fri, 29 May 2009 11:36:34 -0400
Received: from [199.232.76.173] (port=41809 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MA48E-0008QW-2e
	for qemu-devel@nongnu.org; Fri, 29 May 2009 11:36:30 -0400
Received: from mx20.gnu.org ([199.232.41.8]:24246)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MA48D-0004bn-OG
	for qemu-devel@nongnu.org; Fri, 29 May 2009 11:36:29 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MA48C-0003OD-GV
	for qemu-devel@nongnu.org; Fri, 29 May 2009 11:36:28 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir,
	tftp and bootp parameters and -net channel
Date: Fri, 29 May 2009 16:36:25 +0100
References: <20090508103416.6080.44298.stgit@mchn012c.ww002.siemens.net>
	<200905291242.27869.paul@codesourcery.com>
	<4A1FEEED.3090804@siemens.com>
In-Reply-To: <4A1FEEED.3090804@siemens.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905291636.26024.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org

> > It still won't work. You can't assume PATH_MAX is defined at all.
>
> You are right, one cannot always assume its there, but we already do:
>
> block.c:    char tmp_filename[PATH_MAX];
> block.c:    char backing_filename[PATH_MAX];
> qemu-char.c:    char pty_name[PATH_MAX];

I consider these to be bugs, with the possible exception of qemu-char.c which 
appears to be part of an OpenBSD workaround.

Paul