From: Christoph Hellwig <hch@lst.de>
To: Dor Laor <dlaor@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb
Date: Mon, 1 Jun 2009 11:45:58 +0200 [thread overview]
Message-ID: <20090601094558.GA19668@lst.de> (raw)
In-Reply-To: <4A239AEA.7030008@redhat.com>
On Mon, Jun 01, 2009 at 12:10:02PM +0300, Dor Laor wrote:
>
> >From 09ad82d8b8ebd1670aadf21eae8021dfad373c61 Mon Sep 17 00:00:00 2001
> From: Dor Laor <dor@redhat.com>
> Date: Mon, 1 Jun 2009 12:07:23 +0300
> Subject: [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb.
> Also replave qemu_bh_cancel with qemu_bh_delete in bdrv_aio_cancel_em.
> Otherwise the bh will live forever in the bh list.
Looks good to me. Those lifetime rules for QEMUBH objects look
quite awfull to me, though - but this whole don't directly free objects
but rather wait for $event (or forever) scheme seems pretty common in
qemu.
next prev parent reply other threads:[~2009-06-01 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 9:10 [Qemu-devel] [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb Dor Laor
2009-06-01 9:45 ` Christoph Hellwig [this message]
2009-06-23 12:39 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601094558.GA19668@lst.de \
--to=hch@lst.de \
--cc=dlaor@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).