From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MB45m-0007M2-Vn
	for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:46:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MB45h-0007Hb-TV
	for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:46:06 -0400
Received: from [199.232.76.173] (port=45102 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MB45h-0007HV-JS
	for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:46:01 -0400
Received: from verein.lst.de ([213.95.11.210]:50962)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MB45h-0005wC-46
	for qemu-devel@nongnu.org; Mon, 01 Jun 2009 05:46:01 -0400
Date: Mon, 1 Jun 2009 11:45:58 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb
Message-ID: <20090601094558.GA19668@lst.de>
References: <4A239AEA.7030008@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A239AEA.7030008@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dor Laor <dlaor@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>


On Mon, Jun 01, 2009 at 12:10:02PM +0300, Dor Laor wrote:
> 

> >From 09ad82d8b8ebd1670aadf21eae8021dfad373c61 Mon Sep 17 00:00:00 2001
> From: Dor Laor <dor@redhat.com>
> Date: Mon, 1 Jun 2009 12:07:23 +0300
> Subject: [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb.
>  Also replave qemu_bh_cancel with qemu_bh_delete in bdrv_aio_cancel_em.
>  Otherwise the bh will live forever in the bh list.

Looks good to me.  Those lifetime rules for QEMUBH objects look
quite awfull to me, though - but this whole don't directly free objects
but rather wait for $event (or forever) scheme seems pretty common in
qemu.