From: Rusty Russell <rusty@rustcorp.com.au>
To: john cooper <john.cooper@redhat.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] Re: [PATCH 2/2] Add serial number support for virtio_blk, V4
Date: Mon, 1 Jun 2009 16:40:01 +0930 [thread overview]
Message-ID: <200906011640.02632.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A1F615F.1090701@redhat.com>
On Fri, 29 May 2009 01:45:27 pm john cooper wrote:
> virtio_blk-serial-4.patch
Hate to ask dumb questions, but is there a scsi equivalent of this? It'd be
nice if we could avoid being ATA-specific in the long run...
Also, why u16?
Thanks,
Rusty.
> +/* return ATA identify data
> + */
> +static int virtblk_identify(struct gendisk *disk, void *argp)
> +{
> + struct virtio_blk *vblk = disk->private_data;
> + u16 *id;
> + int err = -ENOMEM;
> +
> + id = kmalloc(VIRTIO_BLK_ID_BYTES, GFP_KERNEL);
> + if (!id)
> + goto out;
> +
> + err = virtio_config_buf(vblk->vdev, VIRTIO_BLK_F_IDENTIFY,
> + offsetof(struct virtio_blk_config, identify), id,
> + VIRTIO_BLK_ID_BYTES);
next prev parent reply other threads:[~2009-06-01 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 4:15 [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V4 john cooper
2009-05-31 11:07 ` Christoph Hellwig
2009-06-01 7:10 ` Rusty Russell [this message]
2009-06-03 10:17 ` [Qemu-devel] " Jens Axboe
2009-06-03 15:08 ` john cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906011640.02632.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=hch@lst.de \
--cc=jens.axboe@oracle.com \
--cc=john.cooper@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).