qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: john cooper <john.cooper@redhat.com>
Cc: qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] Re: [PATCH 2/2] Add serial number support for virtio_blk, V4a
Date: Thu, 4 Jun 2009 16:01:16 +0930	[thread overview]
Message-ID: <200906041601.16539.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A26E607.3070901@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Thu, 4 Jun 2009 06:37:19 am john cooper wrote:
> This patch extracts the opaque data from pci i/o
> region 0 via the added VIRTIO_BLK_F_IDENTIFY
> field.  By convention this data takes the form of
> that returned by an ATA IDENTIFY DEVICE command,
> however the driver (except for structure size)
> makes no interpretation of the data.  The structure
> data is copied wholesale to userspace via a
> HDIO_GET_IDENTITY ioctl command (eg: hdparm -i <dev>).

Thanks, applied with one subtraction:

> +/* mapped into pci i/o region 0
> + */
>  struct virtio_blk_config

I removed this comment; it's true for virtio_pci, but not true in general.

Thanks!
Rusty.

[-- Attachment #2: Type: text/html, Size: 1757 bytes --]

  reply	other threads:[~2009-06-04  6:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29  4:14 [Qemu-devel] [PATCH 0/2] Add serial number support for virtio_blk, V4 john cooper
2009-06-03 21:06 ` [Qemu-devel] Re: [PATCH 0/2] Add serial number support for virtio_blk, V4a john cooper
2009-06-03 21:07 ` [Qemu-devel] Re: [PATCH 1/2] " john cooper
2009-06-03 21:07 ` [Qemu-devel] Re: [PATCH 2/2] " john cooper
2009-06-04  6:31   ` Rusty Russell [this message]
2009-06-09 12:19   ` [Qemu-devel] [PATCH] " Rusty Russell
2009-06-09 12:42     ` [Qemu-devel] " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906041601.16539.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=hch@lst.de \
    --cc=john.cooper@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).