From: Christoph Hellwig <hch@lst.de>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fix qemu_aio_flush
Date: Fri, 5 Jun 2009 17:57:39 +0200 [thread overview]
Message-ID: <20090605155739.GA16012@lst.de> (raw)
In-Reply-To: <20090604112645.GQ25483@random.random>
On Thu, Jun 04, 2009 at 01:26:45PM +0200, Andrea Arcangeli wrote:
> Hello,
>
> Kevin has good point that when highlevel callback handler completes we
> should be guaranteed all underlying layers of callbacks events
> completed for that specific aio operation. So it seems the main bug
> was only in qemu_aio_flush() (only made visible by the debug code
> included in the ide_dma_cancel patch). I guess that's a problem for
> savevm/reset that assumes there is no outstanding aio waiting to be
> run while in fact there can be because of the bug. Patch is much
> simpler as seen below:
Yes, this looks better.
prev parent reply other threads:[~2009-06-05 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 16:33 [Qemu-devel] fix bdrv_read/write_em and qemu_aio_flush Andrea Arcangeli
2009-05-30 10:08 ` Christoph Hellwig
2009-05-30 12:17 ` Andrea Arcangeli
2009-06-04 11:26 ` [Qemu-devel] [PATCH] fix qemu_aio_flush Andrea Arcangeli
2009-06-04 11:51 ` [Qemu-devel] " Kevin Wolf
2009-06-05 15:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605155739.GA16012@lst.de \
--to=hch@lst.de \
--cc=aarcange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).